Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mapping legend colorbar #525

Merged
merged 7 commits into from
May 3, 2024
Merged

Mapping legend colorbar #525

merged 7 commits into from
May 3, 2024

Conversation

jordanplanders
Copy link
Contributor

In response to #514 (comment),

  • legend can be turned on and off with legend = True/False
  • colorbar can be turned on and of with colorbar= True/False
  • color scheme can be specified to be discrete using color_scale_type= 'discrete'
  • scalar_mappable can be used to pass a calculated scalar mappable through kwargs
  • marker for modeplot is now set to None by default
  • multiplegeoseries.pca docstring has been updated to include information about colorbar customizations and changing marker variable
  • two helper functions that really should have been in plotting utils are now located there instead of hidden away inside scatter_map function

@alexkjames alexkjames mentioned this pull request Apr 5, 2024
Open
6 tasks
@khider khider requested a review from CommonClimate April 22, 2024 16:58
CommonClimate
CommonClimate approved these changes May 3, 2024
View reviewed changes
Copy link
Collaborator

@CommonClimate CommonClimate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code seems very thoughtful and well-documented. I wouldn't really know how to test it, so I'll put my faith in the CI tests!

@CommonClimate CommonClimate merged commit 0810d2b into master May 3, 2024
1 check passed
@CommonClimate CommonClimate deleted the mapping-legend-colorbar branch May 3, 2024 06:29
@khider khider mentioned this pull request May 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CommonClimate CommonClimate CommonClimate approved these changes

Assignees

@alexkjames alexkjames

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jordanplanders @CommonClimate @alexkjames